On Wed, 18 Mar 2009 15:30:50 +0100 (CET) "Hans Verkuil" <hverkuil@xxxxxxxxx> wrote: > > > On Sat, 14 Mar 2009 16:49:40 +0100 > > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > >> Hi Mauro, > >> > >> Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the > >> following: > >> > >> - v4l2-device: add v4l2_device_disconnect > >> - v4l2: call v4l2_device_disconnect in USB drivers. > >> - tvaudio: add tda9875 support. > > > > Hmm... > > > > tvaudio: add tda9875 support. > > > > From: Hans Verkuil <hverkuil@xxxxxxxxx> > > > > This change allows bttv to use tvaudio for this device. Since this device > > has the same i2c address as the tda9874 we need to support both in the > > same > > tvaudio driver. This makes it possible for tvaudio to detect which chip is > > used. Originally the tda9875 was only available in the dedicated tda9875 > > driver, but that makes life very hard for bttv since loading tvaudio might > > misdetect a tda9875 as a tda9874. > > > > I think we've already discussed about this patch (it were part of your > > bttv RFC > > tree): please remove the mute bug fix for the tda9875 addition. > > > > @@ -1519,23 +1651,26 @@ static int tvaudio_g_ctrl(struct v4l2_su > > > > switch (ctrl->id) { > > case V4L2_CID_AUDIO_MUTE: > > - ctrl->value=chip->muted; > > + if (!(desc->flags & CHIP_HAS_INPUTSEL)) > > + break; > > + ctrl->value = chip->muted; > > return 0; > > > > > > The other changesets are OK. > > Just skip that one. Done. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html