> On Sun, 15 Mar 2009 13:24:00 +0100 > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > >> Hi Mauro, >> >> Can you review my ~hverkuil/v4l-dvb-bttv2 tree? >> >> It converts this driver to v4l2_subdev, and as far as I can see it works >> and >> should probe all the different audio devices in the correct and safe >> order. >> >> I kept things as simple as possible in order to make a review easy. > > Could you please break this changeset even more: > http://linuxtv.org/hg/~hverkuil/v4l-dvb-bttv2/rev/583981be1a4d > > The reason is that it not just add support to tda9875, but also changes > the > behaviour of mute and input selection. Had you find a bug with the old > way? Oops, I'd forgotten about that. That was indeed a bug and should be put in as a separate change. The MUTE support is related to INPUTSEL in tvaudio. But it didn't always test for INPUTSEL. Thanks for catching this. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
