Hi, Some sensor ID is definitely needed at least for Camera daemon and iCapture to load the appropriate tuning data. Ivan can comment which the preferable approach. Best regards, RADO -----Original Message----- From: camera-bounces@xxxxxxxxxxxxxxxxxxxxx [mailto:camera-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Tuukka.O Toivonen Sent: Wednesday, March 04, 2009 4:13 PM To: ext Hans Verkuil Cc: camera@xxxxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx Subject: [Camera] identifying camera sensor Hi, I am writing a generic driver for SMIA-compatible sensors. SMIA-sensors have registers containing: u16 model_id u16 revision_number u8 manufacturer_id which could be used to detect the sensor. However, since the driver is generic, it is not interested of these values. Nevertheless, in some cases user space applications want to know the exact chip. For example, to get the highest possible image quality, user space application might capture an image and postprocess it using sensor-specific filtering algorithms (which don't belong into kernel driver). I am planning to export the chip identification information to user space using VIDIOC_DBG_G_CHIP_IDENT. Here's a sketch: #define V4L2_IDENT_SMIA_BASE (0x53 << 24) then in sensor driver's VIDIOC_DBG_G_CHIP_IDENT ioctl handler: struct v4l2_dbg_chip_ident id; id.ident = V4L2_IDENT_SMIA_BASE | (manufacturer_id << 16) | model_id; id.revision = revision_number; Do you think this is acceptable? Alternatively, VIDIOC_QUERYCAP could be used to identify the sensor. Would it make more sense if it would return something like capability.card: `omap3/smia-sensor-12-1234-5678//' where 12 would be manufacturer_id, 1234 model_id, and 5678 revision_number? I'll start writing a patch as soon as you let me know which would be the best alternative. Thanks! - Tuukka _______________________________________________ Camera mailing list Camera@xxxxxxxxxxxxxxxxxxxxx http://ok.research.nokia.com/cgi-bin/mailman/listinfo/camera -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
