Hi Trent, On Sun, 1 Mar 2009 10:24:08 -0800 (PST), Trent Piepho wrote: > On Sun, 1 Mar 2009, Hans Verkuil wrote: > > > Even though kmalloc supports higher order allocations now, they can > > > easily fail. > > > > The right approach which most drivers take is to allocate up front when the > > driver is loaded. Zoran should be modified to do the same. > > Still, it's a shame to waste the memory when the driver is not in use. This is exactly what the old "highmem" approach was doing. In fact it was worse: you couldn't even reclaim the reserved memory by rmmod'ing the zr36067 driver, you had to reboot your system to get it back. So, having the zr36067 optionally preallocate the capture buffers would still be an improvement compared to the previous situation. > There is a patch that was posted to the mjpeg list that converts the driver > to use the pci dma api. There is something that _is_ in the kernel called > swiotlb that might serve as a replacement for what bigphys_area did. Of course if there is a way to guarantee that memory allocation will succeed, without having to pre-allocate, even better. But my understanding was that the ZR36067's requirements were making this very difficult if not impossible. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
