On Friday 27 February 2009 12:53:28 Hans Verkuil wrote: > On Friday 27 February 2009 12:22:16 Mauro Carvalho Chehab wrote: > > Well, let's merge the code. Maybe someone at the ML could have an Indy > > and can test it. > > > > I think that the risk of breaking vino is not big, since this > > conversion is more like a variable renaming. Also, after applying those > > changes at linux-next, more people can test its code. Maybe we can add > > some printk's asking for testers to contact us at LMML. > > > > I would love to finally remove another V4L1 header (video_decoder.h). > > OK, I'll send the pull request. This will be delayed until early next week. I think I may have forgotten to push some final changes to my vino tree but I won't have access to that PC until Sunday. > > > > Jean, I remember you mentioning that you wouldn't mind if the > > > > i2c-algo-sgi code could be dropped which is only used by vino. How > > > > important is that to you? Perhaps we are flogging a dead horse here > > > > and we should just let this driver die. > > > > > > My rant was based on the fact that i2c-algo-sgi is totally > > > SGI-specific while i2c-algo-* modules are supposed to be generic > > > abstractions that can be reused by a variety of hardware. So > > > i2c-algo-sgi should really be merged into drivers/media/video/vino.c. > > > But as it takes a SGI system to build-test such a change, and I don't > > > have one, I am reluctant to do it. If we can find a tester for your > > > V4L2 conversion then maybe the same tester will be able to test my > > > own changes. > > > > > > But i2c-algo-sgi isn't a big problem per se, it doesn't block further > > > evolutions or anything like that, so if we can't find a tester and it > > > has to stay for a few more years, this really isn't a problem for me. > > > > If the merger of i2c-algo-sgi is as not something complex, then we can > > try to merge and apply at vino. Otherwise, we can just keep as-is. Jean, if you are interested in doing this, then use my v4l-dvb-vino2 tree as the starting point. It would be nice to get it all done in one go. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
