On Mon, 23 Feb 2009, morimoto.kuninori@xxxxxxxxxxx wrote:
>
> Dear Guennadi.
>
> Now MigoR and AP325 board have ov772x camera.
> However, the lens used is different.
>
> And I have a specific good setting value
> for the lens of AP325.
>
> So, I would like to add new function for
> specific lens value.
> meybe like this.
> Can I add it ?
>
> -- board-ap325 ---------------
> static const struct regval_list ov772x_lens[] = {
> { 0xAA, 0xBB }, { 0xCC, 0xDD }, { 0xEE, 0xFF },
> ...
> ENDMARKER,
> }
>
> static struct ov772x_camera_info ov772x_info = {
> ...
> .lenssetting = ov772x_lens,
> }
Hm, lenses can be replaced in principle, right? Does it really make sense
to hard-code them in platform code? Maybe better as module parameter? Or
are these parameters really board-specific?
Thanks
Guennadi
> -----------------
> --- ov772x.c ----
> static int ov772x_start_capture(xxx)
> {
> ...
> if (priv->info->lenssetting) {
> ret = ov772x_write_array(priv->client,
> priv->info->lenssetting);
> if (ret < 0)
> goto error;
> }
> ...
> }
> -----------------
>
> Best regards
> --
> Kuninori Morimoto
>
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
