On 23 Feb, Beat Michel Liechti wrote at linux1394-devel: > --- linux-2.6.28.5-firebranch/drivers/media/dvb/firewire/firedtv-fe.c.orig 2009-02-23 22:25:53.000000000 +0100 > +++ linux-2.6.28.5-firebranch/drivers/media/dvb/firewire/firedtv-fe.c 2009-02-23 22:29:10.000000000 +0100 > @@ -203,6 +203,24 @@ void fdtv_frontend_init(struct firedtv * > FE_CAN_QPSK; > break; > > + case FIREDTV_DVB_S2: > + fi->type = FE_QPSK; > + > + fi->frequency_min = 950000; > + fi->frequency_max = 2150000; > + fi->frequency_stepsize = 125; > + fi->symbol_rate_min = 1000000; > + fi->symbol_rate_max = 40000000; > + > + fi->caps = FE_CAN_INVERSION_AUTO | > + FE_CAN_FEC_1_2 | > + FE_CAN_FEC_2_3 | > + FE_CAN_FEC_3_4 | > + FE_CAN_FEC_5_6 | > + FE_CAN_FEC_7_8 | > + FE_CAN_QPSK; > + break; > + > case FIREDTV_DVB_C: > fi->type = FE_QAM; > I would prefer to make case FIREDTV_DVB_S2 the same as case FIREDTV_DVB_S --- i.e. switch FE_CAN_FEC_AUTO on too since the S2 firmwares are said to support it for standard definition channels. We can revisit this issue when S2API is going to be implemented in the driver. Or does leaving this flag off make an actual difference for you? *If* it really does something, then we can still combine the two case blocks into one, remove the flag from fi->caps = ..., and add if (fdtv->type = FIREDTV_DVB_S) fi->caps |= FE_CAN_FEC_AUTO; before the break. But only if there really is a necessity for having the flag off for FireDTV-S2 boxes in DVB-S usage. -- Stefan Richter -=====-==--= --=- ==--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
