On Mon, 16 Feb 2009 20:33:17 +0100 (CET) Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote: > firedtv is a driver for FireWire-attached DVB receivers from Digital > Everywhere GmbH. The devices are known as FireDTV (external boxes) and > FloppyDTV (internal cards, also connected through FireWire). The driver > supports > - the DVB-C, DVB-S/S2, and DVB-T range of FireDTV and FloppyDTV > models, > - control and reception through Linux' common DVB userspace ABI, > - standard definition video reception (MPEG2-TS, to be decoded > by userspace client software), > - Common Interface for Conditional Access Modules, > - input from infrared remote control. > > High definition support has yet to be added. Also, firedtv still > requires the ieee1394 kernel API but alternative support of the new > firewire kernel API is in progress. > > The driver, formerly known as firesat, was originally written by Andreas > Monitzer. Manu Abraham, Ben Backx, and Henrik Kurelid updated and > extended the driver; I did trivial cleanups, refactoring and small > fixes. > > Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> The driver looks sane to my eyes. I found just one minor issue (see bellow). Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > + > + /* > + * AV/C specs say that answers should be sent within 150 ms. > + * Time out after 200 ms. > + */ > + if (wait_event_timeout(fdtv->avc_wait, > + fdtv->avc_reply_received, > + HZ / 5) != 0) { Instead of using HZ, it would be better to use: msecs_to_jiffies(200) Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html