On Wed, 11 Feb 2009 11:48:56 +0100 (CET) Patrick Boettcher <patrick.boettcher@xxxxxxx> wrote: > Hi Mauro, > > I pushed several changesets to my tree and would like to ask you to pull > them. I'm assuming that you want me to pull from http://linuxtv.org/hg/~pb/v4l-dvb/, right? Please, next time specify the pull url, since people may have more than one tree there. > > - [PATCH] Add support for Winfast Dongle Hybrid > - [PATCH] Emtec S810 (1164:2edc) support > - [PATCH] Add Elgato EyeTV Diversity to dibcom driver Hmm... @@ -1774,7 +1775,7 @@ struct dvb_usb_device_properties dib0700 }, }, - .num_device_descs = 5, + .num_device_descs = 7, .devices = { { "Terratec Cinergy HT USB XE", { &dib0700_usb_id_table[27], NULL }, @@ -1798,6 +1799,10 @@ struct dvb_usb_device_properties dib0700 }, { "Asus My Cinema-U3000Hybrid", { &dib0700_usb_id_table[39], NULL }, + { NULL }, + }, + { "Leadtek Winfast Dongle Hybrid", + { &dib0700_usb_id_table[46], NULL }, { NULL }, }, Just one card were added, but the count were incremented twice... It seems that this patch contains a fix for Asus My Cinema-U3000Hybrid (btw, this reminds me that ARRAY_SIZE() discussion we had). Hmm... $ hg log -r 9042 changeset: 9042:80e9cb79ad03 user: Patrick Boettcher <pb@xxxxxxxxxxx> date: Sun Sep 07 17:43:33 2008 +0200 summary: Add support for Asus My Cinema U3000 Hybrid September, 2008. For sure this were already sent upstream. We should break this into two separate patches, and send the fix patch upstream. Could you please do it? > - Wipe out an obsolete documentation about Flexcop refactoring > - documentation fix for /Documentation/dvb/technisat.txt > > The most important one is > > - [PATCH] software IRQ watchdog for Flexcop B2C2 DVB PCI cards --- a/linux/drivers/media/dvb/b2c2/flexcop.c Wed Feb 11 11:30:08 2009 +0100 +++ b/linux/drivers/media/dvb/b2c2/flexcop.c Wed Feb 11 11:45:09 2009 +0100 @@ -212,8 +212,7 @@ void flexcop_reset_block_300(struct flex v210.sw_reset_210.Block_reset_enable = 0xb2; fc->write_ibi_reg(fc,sw_reset_210,v210); - msleep(1); - + udelay(1000); fc->write_ibi_reg(fc,ctrl_208,v208_save); } Hmm... is it really necessary to have a 1ms udelay here? As you know, udelay() will run a do-nothing loop blocking the CPU until it finishes, while msleep() calls schedule(), letting the processor to do something else while waiting. There are very few cases where udelay() should be used: when the time should be very precise. For most cases, msleep() do a better job. > which fixes a problem with the recently added 2.8 revsion of the Technisat > SkyStar2. If possible we should get that into 2.6.29 in order to have a > proper support for this card. Ok, after pulling it, I'll add to 2.6.29 upstream series. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
