RE: [REVIEW PATCH 2/2] OMAP3EVM Multi-Media Daughter Card Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks,
Vaibhav Hiremath

> -----Original Message-----
> From: Alexey Klimov [mailto:klimov.linux@xxxxxxxxx]
> Sent: Saturday, January 31, 2009 9:59 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; Jadav,
> Brijesh R; Shah, Hardik
> Subject: Re: [REVIEW PATCH 2/2] OMAP3EVM Multi-Media Daughter Card
> Support
> 
> Hello, Vaibhav
> May i tell few suggestions ?
> 
> On Fri, 2009-01-30 at 00:52 +0530, hvaibhav@xxxxxx wrote:
> > From: Vaibhav Hiremath <hvaibhav@xxxxxx>
> >
> > This is second version of OMAP3EVM Mulit-Media/Mass Market
> > Daughter Card support.
> >
> > Fixes:
> >     - Cleaned unused header files, struct formating, and unused
> >       comments.
> >     - Pad/mux configuration handled in mux.ch
> >     - mux.ch related changes moved to seperate patch
> >     - Renamed file board-omap3evm-dc.c to board-omap3evm-dc-v4l.c
> >       to make more explicit.
> >     - Added some more meaningful name for Kconfig option
> >
> > TODO:
> >     - Camera sensor support (for future development).
> >     - Driver header file inclusion (dependency on ISP-Camera
> patches)
> >       I am working with Sergio to seperate/move header file to
> standard
> >       location.
> >     - Still need to fix naming convention for DC
> >
> > Tested:
> >     - TVP5146 (BT656) decoder interface on top of
> >       Sergio's ISP-Camera patches.
> >     - Loopback application, capturing image through TVP5146
> >       and saving it to file per frame.
> >     - Basic functionality of HSUSB Transceiver USB-83320
> >
> > Signed-off-by: Brijesh Jadav <brijesh.j@xxxxxx>
> > Signed-off-by: Hardik Shah <hardik.shah@xxxxxx>
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> > ---
> >  arch/arm/mach-omap2/Kconfig                 |    8 +-
> >  arch/arm/mach-omap2/Makefile                |    1 +
> >  arch/arm/mach-omap2/board-omap3evm-dc-v4l.c |  348
> +++++++++++++++++++++++++++
> >  arch/arm/mach-omap2/board-omap3evm-dc.h     |   42 ++++
> >  4 files changed, 398 insertions(+), 1 deletions(-)
> >  create mode 100644 arch/arm/mach-omap2/board-omap3evm-dc-v4l.c
> >  create mode 100644 arch/arm/mach-omap2/board-omap3evm-dc.h
> >
[Hiremath, Vaibhav] This patch is strongly dependent on ISP-Camera patches, and need rebase/refreshment/synchronization with latest code-base from Sergio and Sakari. I believe they are under process of fixing review comments.

Since there are only minor review comments received for MMDC patch, I will wait till the time Sergio posts the patches supporting ISP-Camera module. And then I will submit it to the community after refreshing on top of it (with review comment fix).
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux