On Fri, 30 Jan 2009, Devin Heitmueller wrote: > On Fri, Jan 30, 2009 at 4:20 AM, Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > > On Thu, 29 Jan 2009, Devin Heitmueller wrote: > >> On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > >> > I haven't been able to test this code. It seems my bt848 card doesn't work > >> > with my SATA controller and I sort of need the latter to access the > >> > harddrive. But I think everything should work. It cuts the the bttv > >> > driver to less than half its current size. > >> > > >> > A number of the changes are for specialized cards that likely have few if > >> > any users left. I'm pretty sure some have been broken for quite a while now. > >> > > >> > Please pull from http://linuxtv.org/hg/~tap/bttv > >> > > >> > bttv-cards.c | 1323 ++++++++++++++++++++++------------------------------------ > >> > bttv-driver.c | 90 +-- > >> > bttv-i2c.c | 6 > >> > bttv-if.c | 18 > >> > bttv-risc.c | 4 > >> > bttv-vbi.c | 2 > >> > bttv.h | 84 ++- > >> > bttvp.h | 19 > >> > 8 files changed, 640 insertions(+), 906 deletions(-) > >> > >> Perhaps I am misunderstanding what you said in this email, but are you > >> submitting a PULL request for 1500 lines of code that have had no > >> testing? > > > > Bugs?! In my code? I think not! > > > > If you look at the patches you'll see it's not nearly as large as it might > > seem. > When I make a five line code change for a given chipset, I won't > submit it unless it's tested against at least three cards. In this > case, it's 1500 lines, and you have tested it on zero cards. You make > one typo or screw up one pointer and we'll have potentially hundreds > of people reporting kernel panics. A typo would almost certainly result in some sort of compile failure or warning. Most of the repetitive changes where mistakes could creep in and not cause an apparent problem were done via perl scripts. Code pulled into v4l-dvb doesn't immediately go to the kernel anyway. It would sit there for a while and get some testing. Anyway, by replacing my PCI-X SATA-II card with a PCI SATA-I card I was able to get my bttv card to work. Or rather I was able to get my HD to work with the bttv card installed. Everything worked fine for my card. The testing I'd like is any of the card with external muxes or digital inputs. Especially the cards that I don't think were working before. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
