On Mon, 2 Feb 2009, morimoto.kuninori@xxxxxxxxxxx wrote: > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx> > > > > Why is this needed? Do you see any possibility for tw9910 to be called > > with an unsupported format? > > for example, > capture_example -f use V4L2_PIX_FMT_YUYV. > but tw9910 support only V4L2_PIX_FMT_VYUY now. But are you actually getting this set_fmt(V4L2_PIX_FMT_YUYV) in your tw9910 driver? If yes, then this is a bug elsewhere. It shouldn't get this far. It should be caught earlier along the path soc_camera_s_fmt_vid_cap() soc_camera_try_fmt_vid_cap() sh_mobile_ceu_try_fmt() soc_camera_xlate_by_fourcc() <error> > If you think this patch is unnecessary, > please ignore it. Could you please test whether you indeed can get an unsupported format in your driver. If so, this is a bug at a higher level and we'll have to fix it there. I'll drop this patch for now. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
