On Mon, 2009-02-02 at 02:46 +0100, e9hack wrote: > Hi, > > this change set is wrong. The affected functions cannot be called from an interrupt > context, because they may process large buffers. In this case, interrupts are disabled for > a long time. Functions, like dvb_dmx_swfilter_packets(), could be called only from a > tasklet. I agree with Hartmut that these functions should not be called from an interrupt context. Although for deferrable work, I thought tasklets were deprecated and that work handlers were the preferred mechanism: http://lwn.net/Articles/23634/ > This change set does hide some strong design bugs in dm1105.c and au0828-dvb.c. > > Please revert this change set and do fix the bugs in dm1105.c and au0828-dvb.c (and other > files). BTW dm1105.c does use a tasklet for IR keypresses. However, since it is only imlemented with one "struct infrared", and hence only one "ir_command", per device and not a queue, it is possible to lose button presses that happen very close together. That probably doesn't matter practically for IR button presses, but the same strategy cannot be used for TS packets. Regards, Andy > Regards, > Hartmut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
