Re: [PATCH 2/2] sh_mobile_ceu: Add FLDPOL operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Guennadi

> > +	value |= common_flags & SOCAM_FLDPOL_ACTIVE_LOW ? 1 << 16 : 0;
> >  	value |= common_flags & SOCAM_VSYNC_ACTIVE_LOW ? 1 << 1 : 0;
> >  	value |= common_flags & SOCAM_HSYNC_ACTIVE_LOW ? 1 << 0 : 0;
> >  	value |= buswidth == 16 ? 1 << 12 : 0;
> 
> Why are you basing your decision to use active low or high level of the 
> Field ID signal upon the platform data? Doesn't it depend on the 
> configuration of the connected device, and, possibly, an inverter between 
> them? So, looks like it should be handled in exactly the same way as all 
> other signals - negotiate with the connected device (sensor / decoder / 
> ...) and apply platform-defined inverters if any?

Hmmm.

The soc_camera framework supports automatic negotiation
for some type of option.
But it doesn't include board configuration.

When board doesn't support Field ID signal,
we will have to modify driver though camera and host support it. 

This is the reason.

I think bus width and field ID are depend on board configuration.
# May be camera strobe. but I'm not sure

Best regards
--
Kuninori Morimoto
 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux