On Sun, 1 Feb 2009, Guennadi Liakhovetski wrote:
> On Fri, 30 Jan 2009, Kuninori Morimoto wrote:
>
> >
> > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> > Signed-off-by: Magnus Damm <damm@xxxxxxxxxx>
> > ---
> > drivers/media/video/sh_mobile_ceu_camera.c | 27 +++++++++++++++++++++++++--
> > include/media/sh_mobile_ceu.h | 5 +++--
> > 2 files changed, 28 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
> > index 9cde91a..07b7b4c 100644
> > --- a/drivers/media/video/sh_mobile_ceu_camera.c
> > +++ b/drivers/media/video/sh_mobile_ceu_camera.c
> > @@ -101,6 +101,29 @@ struct sh_mobile_ceu_dev {
> > const struct soc_camera_data_format *camera_fmt;
> > };
> >
> > +static unsigned long make_bus_param(struct sh_mobile_ceu_dev *pcdev)
> > +{
> > + unsigned long flags;
> > +
> > + flags = SOCAM_SLAVE |
>
> Guys, are you both sure this should be SLAVE, not MASTER? Have you tested
> it? Both tw9910 and ov772x register themselves as MASTER and from the
> datasheet the interface seems to be a typical master parallel to me... I
> think with this patch you would neither be able to use your driver with
> tw9910 nor with ov772x...
Ok, sorry, you, probably, did test it and it worked, but just because the
SLAVE / MASTER flag is not tested in soc_camera_bus_param_compatible(),
which I should fix with the next pull, but this does look wrong. Please,
fix.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
