Re: [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 31 Jan 2009 17:52:05 +0100, Roel Kluin wrote:
> vi drivers/media/common/saa7146_i2c.c +292
> 
> in saa7146_i2c_transfer(..., int retries) 
> {
> 	int address_err = 0;
> 	do {
> 		...
> 		if (...)
> 			address_err++;
> 		...
> 	} while (retries--);
> 
> 	/* if every retry had an address error, exit right away */
>         if (address_err == retries) {
>                 goto out;
>         }
> 	...
> }
> this is wrong, isn't it?

Yes, it looks pretty wrong, however the linux-i2c list isn't the right
place to discuss this.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux