> -----Original Message----- > From: Trent Piepho [mailto:xyzzy@xxxxxxxxxxxxx] > Sent: Thursday, January 29, 2009 11:50 AM > To: Shah, Hardik > Cc: linux-media@xxxxxxxxxxxxxxx; video4linux-list@xxxxxxxxxx; Jadav, Brijesh > R; Nagalla, Hari; Hiremath, Vaibhav > Subject: Re: [PATCHv2] New V4L2 ioctls for OMAP class of Devices > > On Thu, 29 Jan 2009, Hardik Shah wrote: > > 1. Control ID added for rotation. Same as HFLIP. > > 2. Control ID added for setting background color on > > output device. > > 3. New ioctl added for setting the color space conversion from > > YUV to RGB. > > 4. Updated the v4l2-common.c file according to comments. > > Wasn't there supposed to be some documentation? > > > + case V4L2_CID_BG_COLOR: > > + /* Max value is 2^24 as RGB888 is used for background color */ > > + return v4l2_ctrl_query_fill(qctrl, 0, 16777216, 1, 0); > > Wouldn't it make more sense to set background in the same colorspace as the > selected format? [Shah, Hardik] Background color setting can be done only in the RGB space as hardware doesn't understand YUV or RGB565 for the background color setting. And background color and pixel format are not related. If we want to have the background setting format same as the color format then driver will have to do the color conversion and that is not optimal. Regards, Hardik Shah -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
