On Tue, 27 Jan 2009, Shah, Hardik wrote: > The rotation values are 0, 90, 180 and 270 degree but to disable rotation > the value passed should be -1 and this is one more value. I know 0 > degree rotation corresponds to rotation disabled but DSS hardware > requires 0 degree rotation to be enabled for mirroring. The difference > between the 0 degree rotation and no rotation(-1) is that 0 degree > rotation will use the rotation engine in OMAP and then do the mirroring > while -1 degree rotation will not use rotation engine. There is more > bandwidth utilization while using the rotation engine. So people may > want to completely disable rotation and people may want 0 degree rotation > for mirroring support. That's why I prefer not to use enum. Is that ok > for That sounds like a hardware quirk that the driver should take care of. Just have the driver turn on the rotation engine if mirroring is used. It seems very hard for an application to make decent use of rotation support if only certain values are supported by the hardware yet anything in degrees can be specified? How is the application supposed to know what values will be acceptable? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html