Hi,
On Tuesday 13 January 2009, Aguirre Rodriguez, Sergio Alberto wrote:
> Hi,
>
> Recently in TI and Nokia, we are working towards having for acceptance an
> OMAP3 camera driver, which uses an on-chip Image Signal Processor that has
> one feature of color effects. We were using a V4L2 private CID for that,
> but have been suggested that this could be common enough to propose to the
> V4L2 spec aswell for other devices to use.
>
> Below patch adds the control to include/linux/videodev2.h file, should this
> be enough? (This patch is taking as a codebase the latest linux-omap
> kernel, which I believe is v2.6.28 still)
>
> Thanks and Regards,
> Sergio
>
> From 022b87f3e7f3c3be141ab271a110948ea9567a69 Mon Sep 17 00:00:00 2001
> From: Sergio Aguirre <saaguirre@xxxxxx>
> Date: Tue, 13 Jan 2009 16:25:31 -0600
> Subject: [PATCH] V4L2: Add COLORFX user control
>
> This is a common feature on many cameras. the options are:
> Default colors,
> B & W,
> Sepia
>
> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> ---
> include/linux/videodev2.h | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 4669d7e..b02a10d 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -876,8 +876,15 @@ enum v4l2_power_line_frequency {
> #define V4L2_CID_BACKLIGHT_COMPENSATION (V4L2_CID_BASE+28)
> #define V4L2_CID_CHROMA_AGC (V4L2_CID_BASE+29)
> #define V4L2_CID_COLOR_KILLER (V4L2_CID_BASE+30)
> +#define V4L2_CID_COLORFX (V4L2_CID_BASE+31)
> +enum v4l2_colorfx {
> + V4L2_COLORFX_DEFAULT = 0,
If this option disables color effects, shouldn't it be called
V4L2_COLORFX_NONE instead ?
> + V4L2_COLORFX_BW = 1,
> + V4L2_COLORFX_SEPIA = 2,
> +};
> +
> /* last CID + 1 */
> -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+31)
> +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+32)
>
> /* MPEG-class control IDs defined by V4L2 */
> #define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
Best regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
