Hi Antti, >> + buf[0] = (val & 0xFF0000) >> 16; > > I am not sure where it comes I have seen comments sometimes that we > should use lower case hex numbers. OK, will fix. >> + return -EREMOTEIO; > [...] >> + u8 ret, id; > > Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This > seems not to be problem currently because mc44s803_readreg() is used > only in mc44s803_attach() that returns NULL in error case. Anyhow, I > think it would be better to use int for clarity. This is definitely a BUG. I'll also fix this. Do you want me to post an update to the tuner or an incremental patch against your repository? Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
