On Saturday 17 January 2009 13:34:05 Brandon Jenkins wrote: > A pull from v4l-dvb today: > > Kernel build directory is /lib/modules/2.6.27-7-generic/build > make -C /lib/modules/2.6.27-7-generic/build > SUBDIRS=/root/drivers/v4l-dvb/v4l modules > make[2]: Entering directory `/usr/src/linux-headers-2.6.27-7-generic' > ... > /opt/drivers/v4l-dvb/v4l/cx18-driver.c: In function > 'cx18_request_module': /opt/drivers/v4l-dvb/v4l/cx18-driver.c:735: > warning: format not a string literal and no format arguments > > CC [M] /root/drivers/v4l-dvb/v4l/v4l2-common.o > /root/drivers/v4l-dvb/v4l/v4l2-common.c: In function > 'v4l2_ctrl_query_fill': /root/drivers/v4l-dvb/v4l/v4l2-common.c:559: > warning: format not a string literal and no format arguments > /root/drivers/v4l-dvb/v4l/v4l2-common.c: In function > 'v4l2_ctrl_query_menu': /root/drivers/v4l-dvb/v4l/v4l2-common.c:724: > warning: format not a string literal and no format arguments > /root/drivers/v4l-dvb/v4l/v4l2-common.c: In function > 'v4l2_ctrl_query_menu_valid_items': > /root/drivers/v4l-dvb/v4l/v4l2-common.c:742: warning: format not a > string literal and no format arguments > /root/drivers/v4l-dvb/v4l/v4l2-common.c: In function > 'v4l2_i2c_new_subdev': /root/drivers/v4l-dvb/v4l/v4l2-common.c:947: > warning: format not a string literal and no format arguments > /root/drivers/v4l-dvb/v4l/v4l2-common.c: In function > 'v4l2_i2c_new_probed_subdev': > /root/drivers/v4l-dvb/v4l/v4l2-common.c:1008: warning: format not a > string literal and no format arguments I've never seen these warnings, but they seem to be caused by snprintf(dst, size, src), without a proper format string. By itself harmless, but replacing it with strlcpy is better. I did that for v4l2-common.c, but I don't see something similar in cx18_request_module. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
