--- On Thu, 1/15/09, Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote:
> From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
> Subject: Re: [PATCH] Siano 10226 Siano sub-system
> To: "Uri Shkolnik" <urishk@xxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Date: Thursday, January 15, 2009, 7:44 PM
> On Tue, 13 Jan 2009, Uri Shkolnik wrote:
> > --- On Wed, 1/14/09, Trent Piepho
> <xyzzy@xxxxxxxxxxxxx> wrote:
> > > From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
> > > Subject: Re: [PATCH] Siano 10226 Siano sub-system
> > > To: "Uri Shkolnik"
> <urishk@xxxxxxxxx>
> > > Cc: linux-media@xxxxxxxxxxxxxxx
> > > Date: Wednesday, January 14, 2009, 12:54 AM
> > > On Tue, 13 Jan 2009, Uri Shkolnik wrote:
> > > >
> > > > This patch adds Siano subsystem, which
> supports the
> > > CMMB and T-DMB DTV standards.
> > > > The patch also adds Network interface
> (network driver)
> > > in order to support the DVB-H and DAB-IP
> standards.
> > >
> > > Commit messages should be wrapped to 75 columns.
> >
> > Thanks. Will be corrected ASAP.
> >
> > Where can I find checklist for that? (coding style and
> checkpatch.pl are for the source code itself. Which document
> that covers this?)
>
> In the commit message "make commit" you to fill
> in, it says 74 characters.
>
> In README.patches the instructions are slightly different,
> it says 68
> characters for the title and 80 characters for the body of
> the commit
> message. That should probably be updated.
>
> I'm not sure where it says that commit messages in the
> kernel, or simply
> for git in general, should be 75 columns. If you use
> stgit, the initial
> commit message tells you that. I think most developers
> just notice that
> since git indents each line of the commit message by 4
> spaces when you look
> at the commit with git log or git show, that they look like
> crap on an 80
> column terminal if the lines aren't wrapped at 75
> characters.
I fully understand now.
To be on the safe side (maybe too safe), I'll use the minimum (68), even if it might be wrong (7 characters won't effect it much anyway).
Thanks for the explanation.
Uri
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
