Hello, all On Thu, 2009-01-08 at 10:13 -0200, Mauro Carvalho Chehab wrote: > Alexey, > > You should get the driver maintainer's ack or at least let them know that > you're touching on their drivers. Sorry, i didn't know this procedure well enough. > Mike, Thierry an Dean, > > Could you please review this patch? On Thu, 2009-01-08 at 21:52 +0100, Thierry Merle wrote: > It is OK for usbvision. > Just a note with usbvision-video, Mauro you will have a patch rejection due to the recent modification on > usb_endpoint_type(endpoint) != USB_ENDPOINT_XFER_ISOC > changed to > !usb_endpoint_xfer_isoc(endpoint) > This does not change anything to the patched lines we talk about here so: > Acked-by: Thierry Merle <thierry.merle@xxxxxxx> On Thu, 2009-01-08 at 07:39 -0800, dean wrote: > Hi Alexey, > > It looks fine. There's no functional changes in the s2255 driver. It > is good to get rid of the magic string "s2255". The "err to pr_err" > change is the only change I'm not sure about. I have no strong opinion > about it however. Dean, so you think that we don't need s2255 name in the beginning of message and we doesn't need s2255_dev_err macros, right ? As i remember pr_err is just printk with KERN_ERR.. On Thu, 2009-01-08 at 20:57 +0100, Thierry Merle wrote: > Mike Isely wrote: > > Why is this change needed? (Please point me at a discussion thread, if > > you'd like...) > > > > -Mike > > > I remember this list of patches: > https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3708324 > and > https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3709124 > I think this is related. This is just the extension of these modifications. > Thierry That's right. I contacted with Greg KH <greg@xxxxxxxxx> and asked about err-macros in usb.h. It will be removed like info and warn macros. So, we should deal with that in safe good way to make drivers work okay. Maybe there are 3 different patches needed to cover this ? One for usbvision, one for pvrusb2-v4l2.c and one for dabusb ? Another way here - we can define own (private, proper) err macros and use it in v4l drivers. > -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
