Hi Trent, On Thu, 8 Jan 2009 22:01:08 -0800 (PST), Trent Piepho wrote: > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > On Thu, 8 Jan 2009 13:20:19 -0800 (PST) > > Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > > It doesn't seem like any other driver needs to protect the module device > > > table with an ifdef. > > > > However, Zoran driver doesn't rely on pci_register_driver(). Instead, it uses a > > while() loop to probe for Zoran devices: > > > > static int __devinit > > find_zr36057 (void) > > { > > ... > > > > zoran_num = 0; > > while (zoran_num < BUZ_MAX && > > (dev = pci_get_device(PCI_VENDOR_ID_ZORAN, PCI_DEVICE_ID_ZORAN_36057, dev)) != NULL) { > > ... > > } > > Yuck, why don't we fix this instead? > > Here's an initial test. I haven't yet found my dc10+ to test it with. I'm all for it, but what tree was your patch built against? It doesn't seem to apply to anything I have. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html