[PATCH] [RESEND] stb6100: stb6100_init fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Hi Mauro,
> > please look at the patch below.
> > 
> > Signed-off-by: Hans Werner <hwerner4@xxxxxx>
> > 
> > Thanks,
> > Hans
> > 
> > -------- Original-Nachricht --------
> > Datum: Mon, 05 Jan 2009 16:10:50 +0100
> > Von: "Hans Werner" <HWerner4@xxxxxx>
> > An: linux-dvb@xxxxxxxxxxx
> > Betreff: [linux-dvb] [PATCH] stb6100: stb6100_init fix
> > 
> > Two issues in stb6100_init : the call to stb6100_set_bandwidth needs an
> argument in Hz
> > not kHz, and a comment incorrectly says MHz instead of Hz.  I don't know
> if this caused
> > real problems anywhere.
> > 
> > This patch is for v4l-dvb, but it is also needs to be fixed in
> s2-liplianin.
> > 
> > ...
> > ...
> 
> Considering that the ioctl use "state" instead of "status", your patch
> looks
> sane:
> 
> case DVBFE_TUNER_BANDWIDTH:
>                 stb6100_set_bandwidth(fe, state->bandwidth);
> 
> Could you please re-send this patch to me, mentioning the above,
> explicitly C/C
> Manu, linux-media and linux-dvb ML's? Please, mark the patch as a resend.
> 
> Cheers,
> Mauro

Resending the following patch as requested by Mauro.
Signed-off-by: Hans Werner <hwerner4@xxxxxx>

diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c
--- a/linux/drivers/media/dvb/frontends/stb6100.c
+++ b/linux/drivers/media/dvb/frontends/stb6100.c
@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front
        status->refclock        = 27000000;     /* Hz   */
        status->iqsense         = 1;
        status->bandwidth       = 36000;        /* kHz  */
-       state->bandwidth        = status->bandwidth * 1000;     /* MHz  */
+       state->bandwidth        = status->bandwidth * 1000;     /* Hz   */
        state->reference        = status->refclock / 1000;      /* kHz  */

        /* Set default bandwidth.       */
-       return stb6100_set_bandwidth(fe, status->bandwidth);
+       return stb6100_set_bandwidth(fe, state->bandwidth);
 }

 static int stb6100_get_state(struct dvb_frontend *fe,




-- 
Release early, release often.

Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux