On Wed, 7 Jan 2009 11:37:50 +0530 hvaibhav@xxxxxx wrote: > arch/arm/mach-omap2/Kconfig | 4 + > arch/arm/mach-omap2/Makefile | 1 + > arch/arm/mach-omap2/. | 417 +++++++++++++++++++++++++++++++ > arch/arm/mach-omap2/board-omap3evm-dc.h | 43 ++++ > arch/arm/mach-omap2/mux.c | 7 + > arch/arm/plat-omap/include/mach/mux.h | 4 + > +#if defined(CONFIG_VIDEO_TVP514X) || defined(CONFIG_VIDEO_TVP514X_MODULE) > +#include <linux/videodev2.h> > +#include <media/v4l2-int-device.h> > +#include <media/tvp514x.h> This smells like a V4L driver, not an arch driver. We shoud take some care here, to avoid having the drivers on wrong place. The proper place on kernel tree for V4L driver is under drivers/media/video, not under arch/arm. All other architecture-specific V4L drivers are there. > +/* include V4L2 camera driver related header file */ > +#if defined(CONFIG_VIDEO_OMAP3) || defined(CONFIG_VIDEO_OMAP3_MODULE) > +#include <../drivers/media/video/omap34xxcam.h> > +#include <../drivers/media/video/isp/ispreg.h> > +#endif /* #ifdef CONFIG_VIDEO_OMAP3 */ > +#endif /* #ifdef CONFIG_VIDEO_TVP514X*/ Please, don't use ../* at your includes. IMO, the better is to create a drivers/media/video/omap dir, and put omap2/omap3 files there, including board-omap3evm-dc.c. This will avoid those ugly includes. Btw, drivers/media/video/isp/ currently doesn't exist. Please submit the patch for it first. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
