Hello Robert,
On Sat, 3 Jan 2009 12:59:57 -0600
"Robert Krakora" <rob.krakora@xxxxxxxxxxxxxxxxxxxxx> wrote:
> [root@am2mm v4l-dvb]# hg diff
> diff -r 6a189bc8f115 linux/drivers/media/video/em28xx/em28xx-audio.c
> --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Wed Dec 31
> 15:26:57 2008 -0200
> +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Wed Dec 31
> 19:22:38 2008 -0500
> @@ -63,9 +63,12 @@
>
> dprintk("Stopping isoc\n");
> for (i = 0; i < EM28XX_AUDIO_BUFS; i++) {
> + usb_kill_urb(dev->adev.urb[i]);
> usb_unlink_urb(dev->adev.urb[i]);
In this case, em28xx uses usb_unlink_urb() instead of usb_kill_urb().
This function does not wait for the urb to be fully stopped before
return to the caller (needed to avoid an already fixed oops).
> usb_free_urb(dev->adev.urb[i]);
> dev->adev.urb[i] = NULL;
> + kfree(dev->adev.transfer_buffer[i]);
> + dev->adev.transfer_buffer[i] = NULL;
> }
>
Seems ok, please send a new patch with your SOB (Signed-off-by).
Additional info:
http://www.linuxtv.org/wiki/index.php/Development:_How_to_submit_patches
Thanks,
Douglas
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
