Hi Mingye, On Tue, Mar 04, 2025 at 10:29:48PM +0800, Mingye Wang wrote: > Hi Alex, > > Apologies for being so slow (1.75 years! wow) at fixing my patch. Thanks! No problem. :-) > I've corrected > your mentioned deficits (linebreak, version number) and rebased my patch to the > current HEAD at 46b7bca (Feb 27). Please check my work and tell me > what you think. Would you mind sending each patch in a separate mail? As git-send-email(1) does? It makes it much easier to read and reply to each patch. Thanks! See also: <https://web.git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING> Have a lovely day! Alex > > Thanks, > Mingye Wang > > On Sun, Jul 9, 2023 at 3:07 AM Alejandro Colomar <alx@xxxxxxxxxx> wrote: > > > > On 6/5/23 05:13, Mingye Wang wrote: > > > Hi Alex, > > > > > > attached are two patches split and revised as requested. > > > > > > Regards, > > > Mingye > > > > Hi! Here go some comments for one of the patches: > > > > > * random.7: Revise "choice of random source" to remove any recommen- > > > > Don't hyphenate words here. > > > > > +.\" commit 30c08efec8884fb106b8e57094baa51bb4c44e32 > > > +As of Linux 5.6, \fI/dev/random\fP is identical to \fI/dev/urandom\fP, > > > +except that it blocks during early boot. > > > +A jitter-based seeding technique added in Linux 5.4 should help reduce > > > +block time. > > > > Please use semantic newlines. See man-pages(7): > > > > Use semantic newlines > > In the source of a manual page, new sentences should be > > started on new lines, long sentences should be split into > > lines at clause breaks (commas, semicolons, colons, and > > so on), and long clauses should be split at phrase bound‐ > > aries. This convention, sometimes known as "semantic > > newlines", makes it easier to see the effect of patches, > > which often operate at the level of individual sentences, > > clauses, or phrases. > > > > > +.\" commit 50ee7529ec4500c88f8664560770a7a1b65db72b > > > +.PP > > > +The pre-5.6 \fI/dev/random\fP device is a legacy interface which dates > > > +back to a time where the cryptographic primitives used in the implementation > > > +of \fI/dev/urandom\fP were not widely trusted. It would return random bytes > > > -read from both files, but it will not make reads from > > > +read from both files, but it will not make reads from a pre-5.6 > > > > To make it easier to grep, prefix verions with the software name (this > > is done consistently in the pages). So something like 'pre-Linux 5.6' > > would work. > > > > Thanks, > > Alex -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
