On Mon, Mar 03, 2025 at 05:24:45PM +0100, Günther Noack wrote: > Hello Alejandro! Hello Günther! > For context, in this patch set, we have three commits: > > * 1/3 and 2/3 copy documentation from the kernel side unmodified. > * 3/3 revises a section about Landlock's "scoped" restriction features. > > I thought it would be easier to discuss with the "copy" and "rewrite" parts > separate, but actually, as you also noticed, 3/3 does rewrite large chunks of > the 2/3 commit along the way, and it is probably not worth correcting much of > that wording any more. > > Would you prefer if I squashed commits 2/3 and 3/3 into one? I think so. :-) > > > +Setting a flag for a ruleset will isolate the Landlock domain > > > +to forbid connections to resources outside the domain. > > > +.P > > > +This is supported since Landlock ABI version 6. > > > > I'm wondering if we should have this as a parenthetical next to the > > title, like we usually do with "(since Linux X.Y)". Don't do it for > > now, but please consider it for when you have some time. I'm not saying > > you should do it though, just that you consider it, and tell me if you > > agree or not. > > I added it to my notes for further revisions, > I think this would indeed be more appropriate in the man pages. > > Is it possible to set the paranthetical without bold as well, > even in a .SS subsection header? Yes. It requires you to use \f, but you can. We avoid \f as much as possible, but here it's not possible, and I think I've used it already in a few places. Here's an example of how to do it: alx@debian:~/tmp$ cat roman.man .TH a s d f .SH foo .SS bar \f[R]baz\f[] asdf \f[R] starts a roman (non-bold) text, and \f[] reverts to the previous thing, which in this case is bold. > > > +outside of the scope. > > Thanks for the review, > —Günther :-) Have a lovely night! Alex -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
