On 1 March 2025 13:44:56 UTC, Alejandro Colomar <alx@xxxxxxxxxx> wrote: >> > >> Attached is the trivial patch to remove the offending qualifiers. >> > > >> > >Please provide a complete patch, with a commit message. See the files >> > >under <CONTRIBUTING.d/>. >> > >> > Rather than submit a separate email, I have attached a file >> > containing the full output from git-format-patch, > >Yes, that's what I needed (I don't know why people strip the output of >git-format-patch(1); it's easier to just send it as is, I think). :) Initially I had not read enough of the CONTRIBUTING.d docs, so my first patch was just the output from 'git diff'. >> > - having read that an attachment is also an acceptable approach, >> > albeit perhaps not in email form. > >Yes, it is. What you sent this time is just fine. > >Do you think I could improve that documentation that would have >prevented you from sending the first email with the stripped patch? >Do you think anything there is unclear and could be clarified? When first searching for how to submit a patch I found this page: <https://kernel.org/doc/man-pages/maintaining.html> Where the 'Kernel bugzilla' section led me to: <https://web.git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING> I believe I then only read the 'bugs' doc before sending my first message and patch. <https://web.git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/bugs> I suppose I should have been more methodical and read through most or all of the other docs first. However, ideally I might have first come across a single document that just gave an example of what the whole email and patch should look like - even perhaps including that the raw output from git-format-patch is most preferable. This would at least make it immediately clear that the email is really made up of a particularly crafted git commit message + diff. That page could then reference any of the other documents for further detail. I actually didn't realise for a while that the output from format-patch would include email headers, the subject line being the first commit message line, and the message body being the commit message followed by diff patch. >> > If for some reason you feel it should be submitted as a separate >> > email I can do so. >> > This way seemed more prudent for now as this is my first such patch >> > and I'd like to get it right before having multiple threads in the ML. > >You could still send as a separate email in the same thread with >git-format-patch(1)'s --in-reply-to flag (or git-send-email(1), which >has the same flag), which would have been fine, but this is okay too. Thank you. I shall endeavour to remember this in future. Cheers, rahl
Attachment:
signature.asc
Description: PGP signature
