On Thu, Feb 13, 2025 at 9:24 AM Gary Guo <gary@xxxxxxxxxxx> wrote:
>
> On Thu, 13 Feb 2025 06:34:18 -0500
> Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> > ISO C's `aligned_alloc` is partially implementation-defined; on some
> > systems it inherits stricter requirements from POSIX's `posix_memalign`.
> >
> > This causes the call added in commit dd09538fb409 ("rust: alloc:
> > implement `Cmalloc` in module allocator_test") to fail on macOS because
> > it doesn't meet the requirements of `posix_memalign`.
> >
> > Adjust the call to meet the POSIX requirement and add a comment. This
> > fixes failures in `make rusttest` on macOS.
> >
> > Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> > Fixes: dd09538fb409 ("rust: alloc: implement `Cmalloc` in module allocator_test")
> > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
>
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
Thanks for the reviews! Gentle ping: are more reviews required?
