Re: [PATCH] add time64 copies of system calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 20.11.2024 o 23:40, Carlos O'Donell pisze:
On 11/19/24 3:23 AM, Marcin Juszkiewicz wrote:
W dniu 18.11.2024 o 23:51, Alejandro Colomar pisze:
Hi Marcin,

On Mon, Nov 18, 2024 at 08:16:24PM +0100, Marcin Juszkiewicz wrote:
During work on y2038 problem several time related system calls got "64"
or "_time64" copies. It happened only on 32-bit architectures as there
was no problem on 64-bit ones.

Signed-off-by: Marcin Juszkiewicz <marcin@xxxxxxxxxxxxxxxxxx>

This only adds link pages, but doesn't add any documentation for them.
Should we add anything?  Maybe to the SYNOPSIS and VERSIONS (or HISTORY)?

Will look into it.
We absolutely can and should add documentation for the kernel syscalls since they are
unique syscalls that take 64-bit time_t variants for a 32-bit userspace.

These syscalls are the 64-bit time_t variants to allow userspace to build 32-bit targets
that have 64-bit time_t e.g. alternate ABI i686 with 64-bit time_t.

The userspace interfaces are hidden behind a 64-bit time_t though and shouldn't change
(though the ABI changes).

I started looking at it - wondering how much info should be there. Simple like patch below or more complex one?


troff is awful...


diff --git a/man/man2/adjtimex.2 b/man/man2/adjtimex.2
index 7a87ac654..6dde493aa 100644
--- a/man/man2/adjtimex.2
+++ b/man/man2/adjtimex.2
@@ -10,7 +10,7 @@
 .\"
 .TH adjtimex 2 (date) "Linux man-pages (unreleased)"
 .SH NAME
-adjtimex, clock_adjtime, ntp_adjtime \- tune kernel clock
+adjtimex, clock_adjtime, clock_adjtime64, ntp_adjtime \- tune kernel clock
 .SH LIBRARY
 Standard C library
 .RI ( libc ,\~ \-lc )
@@ -22,6 +22,8 @@ .SH SYNOPSIS
 .P
 .BI "int clock_adjtime(clockid_t " clk_id, " struct timex *" "buf" );
 .P
+.BI "int clock_adjtime64(clockid_t " clk_id, " struct timex *" "buf" );
+.P
 .BI "int ntp_adjtime(struct timex *" buf );
 .fi
 .SH DESCRIPTION
@@ -557,6 +559,10 @@ .SH STANDARDS
 .P
 The preferred API for the NTP daemon is
 .BR ntp_adjtime ().
+.SH HISTORY
+Linux 5.1 added
+.BR clock_adjtime64()
+call on 32-bit architectures as part of handling Y2038 problem.
 .SH NOTES
 In struct
 .IR timex ,




[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux