Re: [PATCH] man/man2/stat.2: Add missing 6.11 AT_EMPTY_PATH quirk.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Elliott,

> Subject: Re: [PATCH] man/man2/stat.2: Add missing 6.11 AT_EMPTY_PATH quirk.

Thanks for using the full path!  :)

Regarding "Add missing", I decided to transform that a little bit.
Since most stuff we document was previously undocumented/missing, it
doesn't help much (unless it was undocumented for decades).  I changed
it for "Linux 6.11 allows using NULL with AT_EMPTY_PATH".

On Wed, Jan 08, 2025 at 06:53:17PM -0500, enh wrote:
> Signed-off-by: Elliott Hughes <enh@xxxxxxxxxx>

I prefer if you write the CCd people in the commit message too.
I'll paste it anyway (when I remember).  :)

> diff --git a/man/man2/stat.2 b/man/man2/stat.2
> index 099c56b15..cfbfb654b 100644
> --- a/man/man2/stat.2
> +++ b/man/man2/stat.2
> @@ -175,7 +175,9 @@ can either be 0, or include one or more of the
> following flags ORed:

The patch is corrupted.  The line above seems to have been broken by the
mailer.  :|

Luckily, it was easy enough to apply with the following pipeline:

	sed '/175/N;s/\n/ /' | git am -s


BTW, you should have a look at this:
<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n11>
That will produce more useful hunk contexts.

	$ sed -n 11,19p CONTRIBUTING.d/git 
	   git-diff(1), gitattributes(5)
	       To produce useful hunk contexts in manual pages, we need to hack
	       git(1)'s idea of a function name, and also to tell git what is a
	       manual page.

		   $ git config --global diff.man.xfuncname '^\.S[SHsh] .*$';
		   $ mkdir -p ~/.config/git/;
		   $ echo '*.[0-9]* diff=man' >>~/.config/git/attributes;


Thanks for the patch!  I've applied it.
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=996ca597328f0c93eb6d5eea3e86b6ac277db5f0>


Have a lovely night!
Alex

>  .\" commit 65cfc6722361570bfe255698d9cd4dccaf47570d
>  If
>  .I pathname
> -is an empty string, operate on the file referred to by
> +is an empty string
> +(or NULL, since Linux 6.11)
> +operate on the file referred to by
>  .I dirfd
>  (which may have been obtained using the
>  .BR open (2)
> -- 
> 2.47.1.613.gc27f4b7a9f-goog

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux