On Mon, Jan 06, 2025 at 07:09:58PM +0100, Christoph Hellwig wrote: > On Mon, Jan 06, 2025 at 09:40:07AM -0800, Darrick J. Wong wrote: > > > +stx_dio_offset_align > > > +which must be provided by the file system. > > > > I can't imagine a filesystem where dio_read_offset > dio_offset makes > > sense, but why do we need to put that in the manpage? > > Well, to be backwards compatible to older userspace the value put into > stx_dio_offset_align also needs to work for reads. Given that there > were questions about this in the RFC round I thought I'd mention it. Ah ok then. :) With the other formatting nits fixed, Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> --D