Hi Branden, On Sat, Aug 31, 2024 at 05:16:26PM GMT, G. Branden Robinson wrote: > Hi Alex, > > At 2024-08-31T22:57:57+0200, Alejandro Colomar wrote: > > I'm uncomfortable merging this. The commit message is hard to read. > > Maybe I attempted to explain and reveal too much. Using indentation for the scripts (and cat(1) before a script starts) would probably help. > > > Could you split this change into some simpler smaller patches? > > That's harder. It's a scripted change. I don't think breaking it up by > individual sed commands is going to enlighten anyone. But it would be > easy to break it up by affected file... Do the individual sed(1) commands produce good states? Or are they temporary steps that would not be good by themselves? If any of those states is good, please break there. Cheers, Alex > > > > man/man2/syscalls.2 | 1714 ++++++++++++++++++++++++++++---------- > > > man/man7/namespaces.7 | 32 +- > > > man/man7/signal-safety.7 | 532 +++++++----- > > > man/man7/signal.7 | 66 +- > > > man/man7/suffixes.7 | 64 +- > > ...so that these become 5 patches. Would that be preferable? > > Also just as well that you're not merging, as a few stragglers remain > _still_. However, the size of the problem is getting down to near the > human-remediable scale (fewer than 100). Most look like they'll be > automatically handleable by my "MR-migrate-stage-2-execute.sh" script. > > But I see some exceptions--so far I have spotted wctrans(3) and > wctype(3). I'll send patches along for those, coverting them to tables. > > Regards, > Branden -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
