Re: [PATCH 1/5] stdio.3, signal-safety.7: srcfix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Branden,

Any advances with git-send-email(1)?  I've added some more documentation
for it:

	commit 60660c87e8f75edd9f9d93666315f313dd3743db (HEAD -> contrib, alx/contrib)
	Author: Alejandro Colomar <alx@xxxxxxxxxx>
	Date:   Sat Aug 31 23:38:20 2024 +0200

	    CONTRIBUTING.d/git: Recommend format.thread=true
	    
	    This generates patch sets as threads, with a Message-ID pre-set for the
	    first mail.
	    
	    Cc: "G. Branden Robinson" <branden@xxxxxxxxxx>
	    Signed-off-by: Alejandro Colomar <alx@xxxxxxxxxx>

	diff --git a/CONTRIBUTING.d/git b/CONTRIBUTING.d/git
	index 4f1003a61..0029e7ee2 100644
	--- a/CONTRIBUTING.d/git
	+++ b/CONTRIBUTING.d/git
	@@ -1,38 +1,42 @@
	 Name
		Git - instructions for configuring git(1)
	 
	 Description
	    git-diff(1), gitattributes(5)
		To produce useful hunk contexts in manual pages, we need to hack
		git(1)'s idea of a function name, and also to tell git what is a
		manual page.
	 
		    $ git config --global diff.man.xfuncname '^\.S[SHsh] .*$';
		    $ echo '*.[0-9]* diff=man' >>~/.config/git/attributes;
	 
	    git-format-patch(1)
		Send patches to the right addresses.
	 
		    $ git config --local format.to 'Alejandro Colomar <alx@xxxxxxxxxx>';
		    $ git config --local format.cc '<linux-man@xxxxxxxxxxxxxxx>';
	 
	+       Generate patch sets as a thread.
	+
	+           $ git config --global format.thread true;
	+
	    git-send-email(1)
		If mutt(1) or neomutt(1) are configured in the system,
		git-send-email(1) can be configured to use any of them as a
		driver.  Recent versions of neomutt(1) can enable crypto with -C.
	 
		    $ git config --global \
			    sendemail.sendmailcmd 'neomutt -C -H - && true';
		or
		    $ git config --global sendemail.sendmailcmd 'mutt -H - && true';
	 
	 See also
		git-config(1)
		git-diff(1)
		git-format-patch(1)
		git-send-email(1)
		gitattributes(5)
		mutt(1)
		neomutt(1)
	 
		CONTRIBUTING.d/*


On Sat, Aug 31, 2024 at 04:23:21PM GMT, G. Branden Robinson wrote:
> Hi Alex,
> 
> At 2024-08-31T22:43:04+0200, Alejandro Colomar wrote:
> > On Sat, Aug 31, 2024 at 01:20:27PM GMT, G. Branden Robinson wrote:
> [...]
> > I guess \# doesn't appear in your actual script.  What I usually do to
> > avoid problems with git(1) is to indent everything.
> 
> Reasonable in some circumstances, but I had a second problem--one of the
> sed commands was very long, and I didn't to make an overlong line even
> worse with indentation...
> 
> > > \# blocks to themselves use text blocks, and convert them to use man(7)
> > > \# macros instead of troff(1) font selection escape sequences (which
> > > \# cannot be done outside a text block).
> > > /^\.\\"/b
> > > /^\\fB[^\\]*\\fP([0-9][a-z]*).*T{/s/\\fB\([^\\]*\)\\fP\(([0-9][a-z]*)\)\(.*\)/T{\
> 
> ...thus.

I prefer long lines than scripts that need to be fixed before running.

> 
> > > diff --git a/man/man2/syscalls.2 b/man/man2/syscalls.2
> > > index c259901e7..89c4e7f10 100644
> > > --- a/man/man2/syscalls.2
> > > +++ b/man/man2/syscalls.2
> > > @@ -139,8 +139,8 @@ .SS System call list
> > >  .\" instructive about x86 specifics.
> > >  .\"
> > >  .TS
> > > -Lb Lb Lb
> > > -L2 L  Lx.
> > > +Lb       Lb Lb
> > > +Lw(26n)2 L  Lx.
> > 
> > Ughh, I've applied it.
> 
> I expected you wouldn't like it, and, yes, it's ugly and not
> future-proof,[1] but:
> 
> 1.  It was really important to me to demonstrate that the large changes
>     I was making diff-wise didn't regress the state of the rendered
>     page.  Hence "dump-page.sh" and doing the cmp(1) comparison.
> 
>     When this page was converted to text blocks, the leftmost column
>     shrank by (IIRC) 2 character cells.  I didn't want a corruption of
>     text to hide amid that.
> 
> 2.  The table format can be further changed after the (intrusive) `MR`
>     migration; either restoring the previous or using the `x` column
>     modifier in multiple columns, which I know GNU tbl supports and I
>     think mandoc(1) does too.
> 
> 3.  Indecision about what to do put a lag of a month in following up on
>     my previous "migration preparation" attempt,[2][3] so I decided to
>     just cut through the difficulty by applying the principle in the
>     first point.

Sounds reasonable.  I've applied patches 1, 2, and 3.  I haven't applied
4 and 5.  Please resend, as smaller patches if possible.

Cheers,
Alex

> 
> Regards,
> Branden
> 
> [1] People who pray might want to pray that Linux system call names
>     don't get _even longer_.
> 
> [2] https://lore.kernel.org/linux-man/20240727210927.d3iiwpbvkvtp2mzs@illithid/
> 
> [3] ...although subscribers to the bug-groff and/or groff-commit lists
>     can make some pretty shrewd guesses about what accounts for _most_
>     of the delay.



-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux