Hi Kienan,
On Thu, Aug 29, 2024 at 04:44:49PM GMT, Kienan Stewart wrote:
> See upstream commit:
>
> commit 46c4c9d1beb7f5b4cec4dd90e7728720583ee348
> Author: Alex Xu (Hello71) <alex_y_xu@xxxxxxxx>
> Date: Thu Aug 5 10:40:47 2021 -0400
>
> pipe: increase minimum default pipe size to 2 pages
>
> Signed-off-by: Kienan Stewart <kstewart@xxxxxxxxxxxx>
> ---
>
> Hi Alex,
>
> I appreciate your feedback! I've made the changes requested.
>
> Here is a range-diff against v1 and the new v2 patch.
Thanks! I've applied the patch.
>
> thanks,
> kienan
>
> Range-diff against v1:
> 1: 7957cb086 < -: --------- pipe.7: Note change to default pipe size when soft limit is exceeded
> 2: b0aa965eb ! 1: 4074d2770 pipe.7: Note change to default pipe size when soft limit is exceeded
> @@ man/man7/pipe.7: nor the
> for this user is at this limit,
> -individual pipes created by a user will be limited to one page,
> -and attempts to increase a pipe's capacity will be denied.
> --As of Linux 5.14 the default capacity of individual pipes created
> --by a user is two pages instead. Users may reduce the pipe capacity
> --below this default value.
> +individual pipes created by a user will be limited to two pages
> +(one page before Linux 5.14), and attempts to increase a pipe's
> +capacity will be denied.
This range-diff seems a bit weird. :)
>
> man/man7/pipe.7 | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/man/man7/pipe.7 b/man/man7/pipe.7
> index d1fad9974..ba5b77df3 100644
> --- a/man/man7/pipe.7
> +++ b/man/man7/pipe.7
> @@ -221,8 +221,9 @@ nor the
> capability).
> So long as the total number of pages allocated to pipe buffers
> for this user is at this limit,
> -individual pipes created by a user will be limited to one page,
> -and attempts to increase a pipe's capacity will be denied.
> +individual pipes created by a user will be limited to two pages
> +(one page before Linux 5.14), and attempts to increase a pipe's
> +capacity will be denied.
LGTM. Although, it should be using semantic newlines. See
man-pages(7):
$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
Use semantic newlines
In the source of a manual page, new sentences should be started on
new lines, long sentences should be split into lines at clause
breaks (commas, semicolons, colons, and so on), and long clauses
should be split at phrase boundaries. This convention, sometimes
known as "semantic newlines", makes it easier to see the effect of
patches, which often operate at the level of individual sentences,
clauses, or phrases.
I've amended that myself into the patch, plus some small changes to the
commit message.
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=7543e84442d70a85afc076a1a22fbceef8c283c9>
Have a lovely night!
Alex
> .IP
> When the value of this limit is zero, no soft limit is applied.
> The default value for this file is 16384,
> --
> 2.45.2
>
--
<https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
