Re: man-pages: make install requires git?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Henrik, Sam,

On Tue, Jul 23, 2024 at 08:41:21PM GMT, Henrik Holst wrote:
> Hi Alejandro,
> It seems 'make install' requires 'git' to operate?

It's not actually required; I forgot to silence that error.  The error
is produced while calculating the DISTDATE variable, which you don't
need while installing 6.6.

I fixed that in 6.7, in

	commit 931186249d1896a0c6f32708e6155305698af613
	Author: Alejandro Colomar <alx@xxxxxxxxxx>
	Date:   Thu Feb 15 00:00:55 2024 +0100

	    share/mk/dist/: dist: Support recursive 'dist'
	    
	    Hardcode the version and date, and don't use git(1) for selecting the
	    distribution files.
	    
	    Signed-off-by: Alejandro Colomar <alx@xxxxxxxxxx>

If you want to patch 6.6, you can apply this trivial patch:

	diff --git i/share/mk/version.mk w/share/mk/version.mk
	index af3c0cb2a..f867f25b1 100644
	--- i/share/mk/version.mk
	+++ w/share/mk/version.mk
	@@ -14,7 +14,7 @@ include $(MAKEFILEDIR)/verbose.mk
	 
	 DISTNAME    := $(shell $(GIT) describe $(HIDE_ERR))
	 DISTVERSION := $(patsubst man-pages-%,%,$(DISTNAME))
	-DISTDATE    := $(shell $(GIT) log -1 --format='%aD')
	+DISTDATE    := $(shell $(GIT) log -1 --format='%aD' $(HIDE_ERR))
	 
	 
	 endif  # include guard


I'm guessing you're on Gentoo.  Sam, do you want me to release 6.6.1
with that fix?  Is there anything else that's broken that I should fix?

> Is there a way to make install without having git installed?

You can safely ignore that error.

> (Or should I just silence / ignore errors from bash?)

Yep, it's safe to ignore; I can release a 6.6.1 if that helps.

> [root@zink man-pages-6.06]# bash -exu -c 'make install DESTDIR=/tmp/foo' | head
> + make install DESTDIR=/tmp/foo
> fatal: not a git repository (or any parent up to mount point /)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_ficlone.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_ficlonerange.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_fideduperange.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_fslabel.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_getfsmap.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_iflags.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_ns.2
> INSTALL     /tmp/foo/usr/local/share/man/man2/ioctl_pagemap_scan.2
> INSTALL     /tmp/foo/usr/local/share/man/man2type/
> INSTALL     /tmp/foo/usr/local/share/man/man2type/open_how.2type
> [root@zink man-pages-6.06]# 
> 
> Best,
> Henrik Holst

Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux