On Mon, Jul 22, 2024 at 10:27:23PM +0200, Alejandro Colomar wrote:
> Hi Josef,
>
> On Tue, Jul 09, 2024 at 02:31:23PM GMT, Josef Bacik wrote:
> > Add some documentation for the new listmount syscall.
> >
> > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
>
> Thanks! I've applied the patch with some minor tweaks:
>
> diff --git i/man/man2/listmount.2 w/man/man2/listmount.2
> index 212929fb6..8f7c7afaa 100644
> --- i/man/man2/listmount.2
> +++ w/man/man2/listmount.2
> @@ -4,7 +4,9 @@
> .\"
> .TH listmount 2 (date) "Linux man-pages (unreleased)"
> .SH NAME
> -listmount \- get a list of mount ID's
> +listmount
> +\-
> +get a list of mount ID's
> .SH LIBRARY
> Standard C library
> .RI ( libc ", " \-lc )
> @@ -14,15 +16,15 @@ .SH SYNOPSIS
> .B #include <unistd.h>
> .P
> .BI "int syscall(SYS_listmount, struct mnt_id_req * " req ,
> -.BI " u64 * " mnt_ids ", size_t " nr_mnt_ids ,
> +.BI " uint64_t * " mnt_ids ", size_t " nr_mnt_ids ,
> .BI " unsigned long " flags );
> .P
> .B #include <linux/mount.h>
> .P
> .B struct mnt_id_req {
> -.BR " __u32 size;" " /* sizeof(struct mnt_id_req) */"
> -.BR " __u64 mnt_id;" " /* The parent mnt_id being searched */"
> -.BR " __u64 param;" " /* The next mnt_id we want to find */"
> +.BR " __u32 size;" " /* sizeof(struct mnt_id_req) */"
> +.BR " __u64 mnt_id;" " /* The parent mnt_id being searched */"
> +.BR " __u64 param;" " /* The next mnt_id we want to find */"
> .B };
> .fi
> .P
> @@ -45,7 +47,8 @@ .SS The mnt_id_req structure
> is used by the kernel to determine which struct
> .I mnt_id_req
> is being passed in,
> -it should always be set to sizeof(struct mnt_id req).
> +it should always be set to
> +.IR \%sizeof(struct\~mnt_id_req) .
> .P
> .I req.mnt_id
> is the parent mnt_id that we will list from,
> @@ -69,7 +72,8 @@ .SS The mnt_id_req structure
> .SH RETURN VALUE
> On success, the number of entries filled into
> .I mnt_ids
> -is returned, 0 if there are no more mounts left.
> +is returned;
> +0 if there are no more mounts left.
> On error, \-1 is returned, and
> .I errno
> is set to indicate the error.
>
> Would you mind adding an example program in a new patch?
Yup I can do that, I was going to follow-up with a patch for the new extensions
that have landed in this merge window, after the final release has been cut. Is
it cool if I wait until then, or would you like something sooner? Thanks,
Josef
