Re: [PATCH 1/1] landlock: Mention -1 return code on failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 12, 2024 at 03:09:04PM +0200, Petr Vorel wrote:
> Mention -1 return code on failure for landlock_add_rule(),
> landlock_create_ruleset() and landlock_restrict_self().
> 
> Although it's a common rule to return -1 on error, it's better to be
> explicit (as the other man pages are).
> 
> Fixes: a01d04a69 ("landlock_add_rule.2: Document new syscall")
> Fixes: ca5163697 ("landlock_create_ruleset.2: Document new syscall")
> Fixes: 3f7e4f808 ("landlock_restrict_self.2: Document new syscall")
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
> FYI we test return codes in LTP.
> 
> https://lore.kernel.org/ltp/20240711-landlock-v3-0-c7b0e9edf9b0@xxxxxxxx/
> https://lore.kernel.org/ltp/20240711201306.98519-1-pvorel@xxxxxxx/

Thank you, Petr!  This looks good.
(Please apply Alejandro's rewording suggestion as well.)

Reviewed-by: Günther Noack <gnoack@xxxxxxxxxx>

—Günther





[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux