Re: [PATCH 1/3] statx.2: Document STATX_MNT_ID_UNIQUE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Branden,

On Tue, Jun 25, 2024 at 07:39:45PM GMT, G. Branden Robinson wrote:
> [trimming CC list for this formatting issue]
> 
> At 2024-06-25T14:56:04-0400, Josef Bacik wrote:
> [...]
> > -.in +4n
> > +.in +1n
> >  .TS
> >  lB l.
> >  STATX_TYPE	Want stx_mode & S_IFMT
> > @@ -255,6 +255,7 @@ .SH DESCRIPTION
> >  STATX_MNT_ID	Want stx_mnt_id (since Linux 5.8)
> >  STATX_DIOALIGN	Want stx_dio_mem_align and stx_dio_offset_align
> >  	(since Linux 6.1; support varies by filesystem)
> > +STATX_MNT_ID_UNIQUE	Want unique stx_mnt_id (since Linux 6.8)
> >  .TE
> 
> In my opinion this would have been better done by retaining the existing
> indentation and changing the table to (1) expand the right-hand column
> with the "x" column modifier and (2) using text blocks for lengthy items
> in the right column.  tbl(1) in groff 1.23.0 covers this ground.
> 
> Alex, your acceptance of this patch isn't showing up for me yet.
> 
> $ git remote get-url origin
> https://git.kernel.org/pub/scm/docs/man-pages/man-pages/
> 
> I guess it's only on your staging site so far?

Yep; it's on my staging site.

And I agree; I dislike that +1n.  But I didn't come up with a good
solution.

> 
> Anyway, let me know if you agree.

Sure.  Do you want to send a patch against my remote?

Have a lovely night!
Alex

> 
> Regards,
> Branden



-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux