Re: [PATCH 1/1] ioctl_epoll.2: New page describing ioctl(2) operations for epoll fds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

On Mon, Jun 10, 2024 at 01:16:15PM GMT, Joe Damato wrote:
> I am using Ubuntu 22.04.

Yep, they get the upstream package, I guess.

> I did what you suggested got the same output about s390_sthyi,
> here's what I think is the relevant output:
> 
> SED		.tmp/man/man2/s390_sthyi.2
> <man/man2/s390_sthyi.2 \
> sed "/^\.TH/s/(date)/$(git log --format=%cs -1 -- man/man2/s390_sthyi.2 2>/dev/null)/" \
> | sed '/^\.TH/s/(unreleased)/6.8-152-g97abd8f14-dirty/' >.tmp/man/man2/s390_sthyi.2
> PRECONV		.tmp/man/man2/s390_sthyi.2.tbl
> preconv   .tmp/man/man2/s390_sthyi.2 >.tmp/man/man2/s390_sthyi.2.tbl
> TBL		.tmp/man/man2/s390_sthyi.2.eqn
> tbl <.tmp/man/man2/s390_sthyi.2.tbl >.tmp/man/man2/s390_sthyi.2.eqn
> EQN		.tmp/man/man2/s390_sthyi.2.cat.troff
> ! (eqn -Tutf8   <.tmp/man/man2/s390_sthyi.2.eqn 2>&1 >.tmp/man/man2/s390_sthyi.2.cat.troff) \
> | grep ^ >&2
> TROFF		.tmp/man/man2/s390_sthyi.2.cat.set
> ! (troff -man -wbreak -rS12  -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww  <.tmp/man/man2/s390_sthyi.2.cat.troff 2>&1 >.tmp/man/man2/s390_sthyi.2.cat.set \
>    | grep -v -f '/home/jdamato/code/man-pages/share/mk/build/catman/troff.ignore.grep' \
>    || true; \
> ) \
> | grep ^ >&2
> troff: .tmp/man/man2/s390_sthyi.2:124: warning [p 2, 2.8i]: cannot adjust line
> make: *** [/home/jdamato/code/man-pages/share/mk/build/catman/troff.mk:63: .tmp/man/man2/s390_sthyi.2.cat.set] Error 1

Hmmm; can't reproduce it.  My only difference (AFAICS) is I have
groff-1.23.0, while you'll have groff-1.22.4.  1.22.4 has many many
bugs, so I guess this is one of them.  You can skip this specific error
with

	touch .tmp/man/man2/s390_sthyi.2.cat.set;

Thanks!

> > So what we did is trick make(1) to think that it has successfully run
> > the 'lint-c-checkpatch', by touch(1)ing all the files that would have
> > been created if that target had been successful.
> 
> Ah, I see -- thanks for the pointer!

:-)

> I've re-run make and it is still failing as above but on an
> unrelated file.
> 
> I see in the output that ioctl_epoll seemed to be processed OK:
> 
> SED             .tmp/man/man2/ioctl_epoll.2
> <man/man2/ioctl_epoll.2 \
> sed "/^\.TH/s/(date)/$(git log --format=%cs -1 -- man/man2/ioctl_epoll.2 2>/dev/null)/" \
> | sed '/^\.TH/s/(unreleased)/6.8-152-g97abd8f14-dirty/' >.tmp/man/man2/ioctl_epoll.2
> PRECONV         .tmp/man/man2/ioctl_epoll.2.tbl
> preconv   .tmp/man/man2/ioctl_epoll.2 >.tmp/man/man2/ioctl_epoll.2.tbl
> TBL             .tmp/man/man2/ioctl_epoll.2.eqn
> tbl <.tmp/man/man2/ioctl_epoll.2.tbl >.tmp/man/man2/ioctl_epoll.2.eqn
> EQN             .tmp/man/man2/ioctl_epoll.2.cat.troff
> ! (eqn -Tutf8   <.tmp/man/man2/ioctl_epoll.2.eqn 2>&1 >.tmp/man/man2/ioctl_epoll.2.cat.troff) \
> | grep ^ >&2
> TROFF           .tmp/man/man2/ioctl_epoll.2.cat.set
> ! (troff -man -wbreak -rS12  -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww  <.tmp/man/man2/ioctl_epoll.2.cat.troff 2>&1 >.tmp/man/man2/ioctl_epoll.2.cat.set \
>    | grep -v -f '/home/jdamato/code/man-pages/share/mk/build/catman/troff.ignore.grep' \
>    || true; \
> ) \
> | grep ^ >&2
> GROTTY          .tmp/man/man2/ioctl_epoll.2.cat
> grotty -c  <.tmp/man/man2/ioctl_epoll.2.cat.set >.tmp/man/man2/ioctl_epoll.2.cat
> 
> Should I send a v2? The s390 thing seems unrelated?

Sure; this seems to be good.  I may notice some warnings that are new in
groff-1.23.0 and not present in 1.22.4, but I'll let you know if I see
them.

> What do you think?

Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux