On Fri, Jun 07, 2024 at 12:29:17PM +0200, Alejandro Colomar wrote: > Hi! > > On Thu, Jun 06, 2024 at 07:06:05PM GMT, Joe Damato wrote: > > On Thu, Jun 06, 2024 at 11:39:58PM +0200, Alejandro Colomar wrote: > > > Hi Joe, > > > > > > On Tue, Jun 04, 2024 at 06:17:40PM GMT, Joe Damato wrote: > > > > Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx> > > > > > > Thanks for the patch! Please see a few comments below. > > > > I've included some questions below just to make sure I give you a v2 > > that is much closer to correct :) > > Nice :) [ ... ] I think I've incorporated all of your feedback and given it a good rewrite. Once I sort out the linting issue in the other thread (and fix any issues that finds), I should be ready to send a v2 that I hope will be much closer to correct. Thanks for your detailed and thoughtful review, Joe
