On Sat Mar 16, 2024 at 12:45 PM NZDT, Alejandro Colomar wrote: > This patch is too big, and changes too much, for a single patch, I > think. Please split the patch into smaller patches that do one thing, > and document those more precisely in the commit messages, instead of > something generic, if possible. See <./CONTRIBUTING.d/patches>: > > - Send logically separate patches. For unrelated pages, or for > logically-separate issues in the same page, send separate > emails. Hi Alex, at the time of writing I considered it appropriate according to that guideline but yes I agree it is too generic. > Please use semantic newlines (see man-pages(7)): > > $ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p' > Use semantic newlines > In the source of a manual page, new sentences should be started > on new lines, long sentences should be split into lines at clause > breaks (commas, semicolons, colons, and so on), and long clauses > should be split at phrase boundaries. This convention, sometimes > known as "semantic newlines", makes it easier to see the effect > of patches, which often operate at the level of individual sen‐ > tences, clauses, or phrases. Sweet, will do. Thanks! ~Jeremy