Hi Alejandro, On Mon, Feb 12, 2024 at 12:49:32AM +0100, Alejandro Colomar wrote: > Thanks! LGTM, but please check a small comment below. > > > --- > > man2/close_range.2 | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/man2/close_range.2 b/man2/close_range.2 > > index 380a47365..62b728e96 100644 > > --- a/man2/close_range.2 > > +++ b/man2/close_range.2 > > @@ -11,10 +11,13 @@ Standard C library > > .RI ( libc ", " \-lc ) > > .SH SYNOPSIS > > .nf > > -.B #include <linux/close_range.h> > > +.BR "#define _GNU_SOURCE" " /* See feature_test_macros(7) */" > > +.B #include <unistd.h> > > +.P > > +.BR "#include <linux/close_range.h>" " /* For the flags constants */" > > Could you please format the comment like other pages that do the same > thing? See for example membarrier(2). Sorry, you have to be more explicit what exactly you believe is not the same thing that other pages do. membarrier.2 doesn't need a _GNU_SOURCE define and I believe I used the comment as other pages that do. Cheers, Mark
