On Wed, Oct 11, 2023 at 04:53:20PM -0400, Rik van Riel wrote: > On Wed, 2023-10-11 at 22:14 +0200, Alejandro Colomar wrote: > > Hi Rik, > > > > On Wed, Oct 11, 2023 at 12:53:30PM -0400, Rik van Riel wrote: > > > Sigh, once again I did a git commit --amend without the latest file > > > change being > > > included. The change below should be good. Working with both git > > > and hg gets me sometimes :/ > > > ---8<--- > > > > > > The execve syscall returns -E2BIG in 3 cases: > > > - The total length of the command line arguments and environment is > > > too large. > > > - An argument or environment string is longer than MAX_ARG_STRLEN. > > > > I'm still concerned by the wording of this sentence (and the next > > one). > > When I (and any user-space programmer, I think) read "string is > > longer > > than FOO", I read `strlen(string) > FOO`. Since it's rather > > `strlen(string) >= FOO`, I think you should clarify. How about this? > > > > - An argument or environment string is longer (including the null > > byte) > > than MAX_ARG_STRLEN. > > That works. Would you like me to re-send a v5, or do you > want to massage the changelog when you apply the patch? > > I must admit I paid more attention to the wording in the > man page than the wording in the changelog :) I wouldn't mind doing it myself, but I'll ask you to resend, if you don't mind. I usually find that doing so helps catch other accidents that I didn't catch. :) Cheers, Alex > > -- > All Rights Reversed. :) -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
