On Mon, 25 Sept 2023 at 15:20, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Mon, 25 Sept 2023 at 15:19, Christian Brauner <brauner@xxxxxxxxxx> wrote:
> >
> > > How about passing u64 *?
> >
> > struct statmnt_req {
> > __u64 mnt_id;
> > __u64 mask;
> > };
> >
> > ?
>
> I'm fine with that as well.
So after a bit more thinking: this is okay to make life easier for
32bit archs, but only on the kernel ABI.
On the library API the args should *not* be multiplexed, as it's just
a pointless complication. This is just an internal implementation
detail for the sake of legacy architectures, instead of being good API
design.
And because it's an internal thingy, my feeling is that this struct
could be reused for passing mnt_id to listmount(2) as well, despite
the fact that the mask would be unused. But I'm ready to be
convinced otherwise...
Thanks,
Miklos
