Re: [PATCH v2] memcmp.3: Recast security caveat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

At 2023-07-30T19:31:39+0200, Alejandro Colomar wrote:
> On 2023-07-30 17:31, G. Branden Robinson wrote:
> > Use terminology more carefully.
> > 
> > * Refer to the info sec property of confidentiality instead of saying,
> >   vaguely, "security-critical".
> >     https://informationsecurity.wustl.edu/items/\
> >     confidentiality-integrity-and-availability-the-cia-triad/
> > * Try not to confuse anyone who's studied the analysis of algorithms:
> >   don't say "constant time" when "deterministic time" is meant.  The
> >   time to perform the memory comparison remains linear (O(n)), not
> >   constant (O(1)).
> > * Tighten wording.
> 
> I prefer 2 spaces between the bullet and the list contents.  See
> man-pages(7).  Anyway, I accepted it this time.  :)

This had me confused for a while, since I had no tagged paragraphs in
the patch.  You must mean in the commit message, too.  I don't think
that's documented...?  I guess it should go in the "CONTRIBUTING" file.

> You need to quote your name with '"' due to the '.'.  I've found
> some software has issues with it.  git-send-email(1) is one of them
> (due to the perl library it uses).

Thanks--I fixed my vi ":ab" command to take care of this.

Regards,
Branden

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux