Re: [PATCH] man5/tmpfs.5: fix typo in reference to CONFIG_TRANSPARENT_HUGEPAGE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/19/23 12:59, Alejandro Colomar wrote:
On 2023-07-19 04:05, John Hubbard wrote:
In commit 462a385e9a2 ("tmpfs.5: Document current mount options"), there
is a reference to CONFIG_TRANSPARENT_HUGE_PAGECACHE. However, that
option was removed from the kernel via commit 396bcc5299c2 ("mm: remove
CONFIG_TRANSPARENT_HUGE_PAGECACHE"), a couple of years later.

The net effect is that CONFIG_TRANSPARENT_HUGEPAGE is now used in all
the remaining places in the kernel where
CONFIG_TRANSPARENT_HUGE_PAGECACHE had previously been used.

This has caused some minor confusion at the man page level, though. So
let's fix it by updating the man page to also refer to
CONFIG_TRANSPARENT_HUGEPAGE.

Reported-by: Vahid Noormofidi <vnoormof@xxxxxxxxxx>
Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Cc: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Carsten Grohmann <carstengrohmann@xxxxxx>
Cc: Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>

Accident here :-)


Yes. :)  Michael Kerrisk, could you change that line for me
to just be a Cc, for Mike Frysinger?

Or, let me know if you'd prefer a re-send of the patch instead.


thanks,
--
John Hubbard
NVIDIA


Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
---
  man5/tmpfs.5 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man5/tmpfs.5 b/man5/tmpfs.5
index 09d955898..cdd5f2fd8 100644
--- a/man5/tmpfs.5
+++ b/man5/tmpfs.5
@@ -115,7 +115,7 @@ Set the initial user ID of the root directory.
  .BR huge "=\fIhuge_option\fR (since Linux 4.7.0)"
  .\" commit 5a6e75f8110c97e2a5488894d4e922187e6cb343
  Set the huge table memory allocation policy for all files in this instance (if
-.B CONFIG_TRANSPARENT_HUGE_PAGECACHE
+.B CONFIG_TRANSPARENT_HUGEPAGE
  is enabled).
  .IP
  The

base-commit: c654cde5ec9e9fa975d5d041aa069489ab12a4ce






[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux