Hi!
On 4/10/23 21:57, Nadav Amit wrote:
>
>> On Apr 8, 2023, at 6:34 AM, Alejandro Colomar <alx.manpages@xxxxxxxxx> wrote:
>>
>> Hi Nadav,
>>
>> On 3/7/22 19:48, Nadav Amit wrote:
>>> From: Nadav Amit <namit@xxxxxxxxxx>
>>>
>>> A bug in the kernel caused in recent version a different output (masked
>>> offset). Update the output of the demo program accordingly.
>>
>> I'd like to have some more information about this in the commit message.
>> I don't really understand it. When was the bug introduced? When was it
>> fixed? Was the example in the page created in a buggy version?
>
> Hi Alex,
>
> Sorry for the late response.
>
> The bug was introduced in 1a29d85eb0f1 ("mm: use vmf->address instead of of
> vmf->virtual_address”) which is circa 2016. It was introduced shortly after
> userfaultfd, so it was determined that no users are likely to rely on the
> intended correct behavior that was documented in the man page, but there
> might be users who relied on the wrong behavior, which was in the code
> for several years.
>
> More information is available in the patch of the fix:
>
> https://lore.kernel.org/all/20220226022655.350562-1-namit@xxxxxxxxxx/
>
> Let me know if it answers you questions, and whether you want me to send
> an updated patch for the man page.
Yes, please, a patch including all this response in the message would be
useful.
Thanks!
Alex
>
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
